search

amtgard / ORK3

Version 3 of the Online Record Keeper
Other
23 stars 12 forks source link

Change response encoding to UTF-8 #197

Open p0lar-bear opened 6 years ago

p0lar-bear commented 6 years ago

I get a feeling this would be a very simple change but I'm sure I'm in such a weird use-case that this is probably the lowest of priorities, but,

I was tinkering with Xamarin.Forms to make a test app to interface with ORK3, and the tool that Visual Studio 2017 provides to generate proxy classes for the SOAP services only accepts WSDL files encoded in UTF-8 or UTF-16. The WSDL files are being served in ISO-8859-1 encoding. In this day and age, most textual data seems to be encoded in unicode, and I think it might be a good idea to follow suit.

esdraelon commented 6 years ago

This is actually more complicated than it looks. The SOAP module used in the ORK predates the built-in SOAP server that eventually shipped with PHP, so it's entirely custom. There are about 57 references to ISO-8859-1, and it's not clear what the interplay of ISO vs UTF-8 are in the library code.

Also, while the SOAP WSDL is convenient, it is on track to being deprecated (I know ... our communication around that is really poor ...).