search

amtgard / ORK3

Version 3 of the Online Record Keeper
Other
23 stars 11 forks source link

Would like a limit on Player/AttendanceForPlayer #209

Closed kenwalker closed 5 years ago

kenwalker commented 5 years ago

I'm writing an application in which I'd like to show the last attendance a user had. As it is, there's no limit on the AttendanceForPlayer API call so you get all the records. I'll submit a pull request with the limit parameter optional for this API call so that my app won't waste unnecessary bandwidth on devices to retrieve this player detail.

mathus13 commented 5 years ago

Do you see this best as a date limit or a count by December order

On Sat, Apr 6, 2019, 9:55 AM Ken Walker notifications@github.com wrote:

I'm writing an application in which I'd like to show the last attendance a user had. As it is, there's no limit on the AttendanceForPlayer API call so you get all the records. I'll submit a pull request with the limit parameter optional for this API call so that my app won't waste unnecessary bandwidth on devices to retrieve this player detail.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/amtgard/ORK3/issues/209, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcEicltzH_BIhX6h6TxUu04noKEl2dHks5veKdZgaJpZM4cgNhg .

kenwalker commented 5 years ago

For now by descending order since that's an easy change. Date would also be very useful for computing if someone was attendance qualified for example (N times in last M months where the computation is not the same as what's used by the ORK proper) and so you don't need to retrieve ALL their attendance. I may do that as a follow on PR.

kenwalker commented 5 years ago

I mean count from current attendance down to zero from the limit parameter. My wording above was not great.

mathus13 commented 5 years ago

fixed in #210