search

amtgard / ORK3

Version 3 of the Online Record Keeper
Other
23 stars 12 forks source link

Reverse order of heraldry & image #255

Closed jkat718 closed 3 years ago

jkat718 commented 4 years ago

With the current order, the heraldry comes first and is therefore what is used in web previews (like on Facebook). Since, anecdotally, more people have images set than heraldry, this mean most ORK page profiles just have the placeholder image in their previews. By reversing the order, the more commonly-used field is on top and more accessible and would be used for previews.

jrtaylor-com commented 3 years ago

This request doesn't actually require the template be "reordered". We just need to add an og meta tag in the header. EX: <meta property="og:image" content="http://euro-travel-example.com/thumbnail.jpg"> I dont think we are passing player info in the header at the moment, but I'll take a look

jrtaylor-com commented 3 years ago

In the interim I've created the above PR that sets the ogimage meta tag to use the ORK's logo. This is a quick compromise for a better social media linking experience. At some point we can see about passing more data to the header that could be use logic to display either the headshot or the heraldry if they exist. At that point we could also update the title to be more descriptive which would help what your request is going for.