search

amtgard / ORK3

Version 3 of the Online Record Keeper
Other
23 stars 10 forks source link

Issue237 resident date field #261

Closed jrtaylor-com closed 3 years ago

jrtaylor-com commented 3 years ago

This PR requires a db-migration for the production DB. It is already in place on the DEV DB

kenwalker commented 3 years ago

I tested this out locally, I also updated my local JSORK code to be able to show and update the value and I tried bogus values which did not fail but resulted in a date of "0000-00-00". I tried transfers and they correctly set the date. I tried a new player and it did not correctly set the date so I pushed a change which should fix this. Please have a look at that.

kenwalker commented 3 years ago

I'm a bit worried that this field is blank for all players. I'm not sure of the right date we could set for it, certainly any player that took credits anywhere else? The first credit they took at their current park?