Closed jrtaylor-com closed 3 years ago
The existing method of setting and retrieving dues paid no longer works. When retrieving player information, "DuesThrough" is empty. If you set it via the existing player via UpdatePlayer with "DuesDate" and "DuesSemesters" it does not propagate thru to the new table and thus does not show up in your dues list. The player page still has the old entry area for dues and could be punted.
The existing method of setting and retrieving dues paid no longer works. When retrieving player information, "DuesThrough" is empty. If you set it via the existing player via UpdatePlayer with "DuesDate" and "DuesSemesters" it does not propagate thru to the new table and thus does not show up in your dues list. The player page still has the old entry area for dues and could be punted.
The old dues bit will be greyed out(disabled), and I will add a popup when they try to change it. I am leaving some of the old UI accessible for a short while during the transition phase as people get up to speed. Thanks for the reminder to change that UI
The old dues bit will be greyed out(disabled), and I will add a popup when they try to change it. I am leaving some of the old UI accessible for a short while during the transition phase as people get up to speed. Thanks for the reminder to change that UI
Ok that's cool. But the existing API, that can be made to work, correct?
The old dues bit will be greyed out(disabled), and I will add a popup when they try to change it. I am leaving some of the old UI accessible for a short while during the transition phase as people get up to speed. Thanks for the reminder to change that UI
Ok that's cool. But the existing API, that can be made to work, correct?
I'm sure, point me to how you are accessing the methods and I can update the API to use what was just added
For setting Dues should be this line in UpdatePlayer: https://github.com/amtgard/ORK3/blob/master/system/lib/ork3/class.Player.php#L810
For retrieving Dues in the Player information should be here: https://github.com/amtgard/ORK3/blob/master/system/lib/ork3/class.Player.php#L216
Confirmed player with no privs cannot see mundane names Confirmed player with park privs can only see park mundane names Confirmed player with kingdom can see kingdom/park mundane names Confirmed player with added auth capabilities can only see mundane names from that auth
If you do not have the privilege to revoke dues but try you get redirected to a web page that just says "Revoke dues called"
@kenwalker pushed a new commit to fix the revoke no auth blank page issue, disabled the old dues UI, added Dues to the get_player method
This shouldn't have been merged yet. I haven't approved it and the backwards compatibility with existing APIs.
…old dues
Run table migration before import
Tests needed: Only authorized users should see Mundane name on Dues Reports Create/Read/Revoke Links