amtgard / ORK3

Version 3 of the Online Record Keeper
Other
23 stars 10 forks source link

Custom Pronoun options are not removed correctly and selection of existing ones not working for some #324

Closed kenwalker closed 1 year ago

kenwalker commented 1 year ago

Found a couple of issues with the custom pronoun picker and how the values are saved, used for re-selection on opening the dialog again, and how they're cleared if you don't want to have any anymore. Set an initial selection and close the dialog

Initial selection

Reopen dialog, some selections missing

Reopen dialog missing selections

Clear all selections and save dialog

Clear all selections

A partial text version is displayed vs no text at all which overrides the non-custom pronoun choice is made

Empty array saved

Partial text displayed

Empty array displayed

After bug fix the selections should return properly each time and if you clear all the selections, there will be no saved text and the non-custom pronoun will be the preferred display value.

With fix for no selected custom pronouns
kenwalker commented 1 year ago

Fix deployed