search

amtgard / ORK3

Version 3 of the Online Record Keeper
Other
23 stars 12 forks source link

Merge Player function does not move reconciled credits to destination player #350

Open kenwalker opened 2 months ago

kenwalker commented 2 months ago

In the Player MergePlayer function it does not appear to have the necessary SQL code to move any reconciled credits to the merged player. Likely this should combine the two together?

https://github.com/amtgard/ORK3/blob/9b184759e8e14a02841f326bcef5e15e4283f071/system/lib/ork3/class.Player.php#L641

kenwalker commented 2 months ago

After discussion with @megiddo we think it better to document in the UI what is and isn't merged in the process. Since you can always modify the destination player's reconciled credits as needed.