search

amtgard / ORK3

Version 3 of the Online Record Keeper
Other
23 stars 11 forks source link

Editing Unit "members" fills in Role as "Data Entry" #85

Closed Glenalth closed 6 years ago

Glenalth commented 9 years ago

When editing from the Members section of a unit, if you select a "Member" role player, the role field automatically fills with "Data Entry". If you select someone with the "Captain" role it fills in properly. I did not test with "Lord" or "Organizer."

jrtaylor-com commented 6 years ago

Both Member and Data Entry roles have a value of "member" So the selected value could be more of a display issue if the two roles should be "member" otherwise the value for the Data Entry role needs to be defined so that we can update that value.

jrtaylor-com commented 6 years ago

@Glenalth per my last comment, should we be updating the underlying value of the Data Entry selection?

Glenalth commented 6 years ago

I thought I had responded to this previously...

I don't believe there is a need for the "Data Entry" role at all unless there is some underlying mechanic for giving permissions to edit or add attendance for events created by an event unit.

jrtaylor-com commented 6 years ago

Ok looks like we can remove that select option from the template. Thanks!

@esdraelon branch https://github.com/amtgard/ORK3/tree/fix/unit/issue85-remove-data-entry-role will resolve this issue

esdraelon commented 6 years ago

Fixed and released in branch sprint-2017-10-16