search

amtoine / dotfiles

My personal archlinux config files.
GNU General Public License v3.0
21 stars 2 forks source link

Quote source paths in reload_config keybinding #86

Closed RickCogley closed 1 year ago

RickCogley commented 1 year ago

I use macOS and installed nushell via brew. It installs configs in a path that contains a space (blurgh), so when I tried your reload_config keybinding as is, it fails. Per the discussion on discord, I tested surrounding the paths being fed to the source commands with "", then '', and while either of those work on a mac, someone mentioned that only '' works on Windows, so I added '' around the path expansions to handle the case where those paths might contain a space.

amtoine commented 1 year ago

thanks @RickCogley

RickCogley commented 1 year ago

My pleasure :)

From: Antoine Stevan @.> Sent: Saturday, April 8, 2023 6:10 PM To: goatfiles/dotfiles @.> Cc: Rick Cogley @.>; Mention @.> Subject: Re: [goatfiles/dotfiles] Quote source paths in reload_config keybinding (PR #86)

thanks @RickCogleyhttps://github.com/RickCogley

— Reply to this email directly, view it on GitHubhttps://github.com/goatfiles/dotfiles/pull/86#issuecomment-1500831907, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAD5CSEIHW3AV5OURXXUDCDXAETPPANCNFSM6AAAAAAWWAVQZE. You are receiving this because you were mentioned.Message ID: @.***>