search

amtrack / force-dev-tool

[DEPRECATED] Command line tool supporting the Force.com development lifecycle
MIT License
108 stars 37 forks source link

fix: add all files for LightningComponentBundle #209

Closed leboff closed 5 years ago

leboff commented 5 years ago

Fixes issue with LightningComponentBundles so all files from the bundle are added to package when one file is changed (similar to Aura bundles)

leboff commented 5 years ago

Should work now right? Or does the commit message need to be updated too?

amtrack commented 5 years ago

yes, I think that’s fine now.

leboff commented 5 years ago

@amtrack I don't think that worked (according to the deploy log)

amtrack commented 5 years ago

@leboff oops! That happened to me before. I should have known :-/ I (kind of) resolved it last time by creating an entry commit with the correct message: https://github.com/amtrack/force-dev-tool/commit/0d8e06cd2a229dc760b4f5716289a13b3a332f94 But I’m open to other solutions!

amtrack commented 5 years ago

:tada: This PR is included in version 2.4.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

leboff commented 5 years ago

that worked. released now. Thanks!

amtrack commented 5 years ago

@leboff I've installed https://github.com/probot/semantic-pull-requests for this repo. As they explain in their README, a semantic PR title is OK, if you squash and merge the PR. By only merging the PR, the PR title gets lost.