search

amtrack / force-dev-tool

[DEPRECATED] Command line tool supporting the Force.com development lifecycle
MIT License
108 stars 37 forks source link

feat: support to custom notification type #212

Closed froucher closed 4 years ago

froucher commented 4 years ago

https://github.com/amtrack/force-dev-tool/issues/211

froucher commented 4 years ago

Hello,

I have successfully create a local test with a CustomNotificationType, create a delta, and deployed with ant the delta folder. Please @amtrack let me know if you need something more to validate this change.

Thanks!

amtrack commented 4 years ago

@froucher Thanks for your PR. Please look at my comments.

froucher commented 4 years ago

Ok, thanks for your comments, then I will test both suffix changes and update this thread with the result.

froucher commented 4 years ago

Hi @amtrack,

I have fixed suffix of customNotificationTypes, lightningExperienceThemes and BrandingSets, and tested again if the delta is well created for the three metadata, and it seems all is working right.

Please let me know if I must test something more.

Thanks!

froucher commented 4 years ago

Hi,

Just for clarification, these are examples of suffixes:

force-app/main/default/brandingSets/LEXTHEMINGThemeTest.brandingSet-meta.xml force-app/main/default/lightningExperienceThemes/ThemeTest.lightningExperienceTheme-meta.xml force-app/main/default/notificationtypes/forcedevtool_custom_notification_test.notiftype-meta.xml

src/lightningExperienceThemes/ThemeTest.lightningExperienceTheme src/notificationtypes/forcedevtool_custom_notification_test.notiftype src/brandingSets/LEXTHEMINGThemeTest.brandingSet

Regards

amtrack commented 4 years ago

@froucher The changes look good! Would it be possible for you to cleanup this PR to only contain two commits with the following commit messages?

I would like the release notes to be generated nice and clearly ;-)

froucher commented 4 years ago

Sure, I have created a new clean Pull Request https://github.com/amtrack/force-dev-tool/pull/213 from a new origin branch.

amtrack commented 4 years ago

closing in favor of #213