Closed froucher closed 4 years ago
Hello @amtrack,
How are you? Maybe it could be helpful to have a session to review this PR. Please let me know if it is interesting from you side.
Regards and thank you
Hello @amtrack,
How are you? Maybe it could be helpful to have a session to review this PR. Please let me know if it is interesting from you side.
Regards and thank you
@froucher Thanks, I'm doing well. Yes, let's do a session. I'll contact you via email regarding an appointment.
@froucher I have one minor change request, besides that this PR looks good to me.
Apparently the metadataContainer
constructed in these lines isn't used anymore by your implementation, so that explicitly creating changesets using command line arguments (e.g. force-dev-tool changeset create mytestclass ApexClass/FooTest
) doesn't work anymore.
I've now relocated the corresponding test from test-integration
to test
(#267) so that it is run in CI for Pull Requests.
Can you please rebase your PR to latest master branch and try to integrate the metadataContainer
instance again?
Hi,
Done, it fails...
A previous question, when I wanted to create a changeset with one file, I usually executed a command like:
git diff master..HEAD -- ApexClass/FooTest | force-dev-tool changeset create mytestclass
Maybe this workaround could replace the functionality.
Anyway, for backward compatibility, I will review the source code to understand why is not supported.
Thanks.
Hi @amtrack,
I resolved the issue about explicitly creating changeset using command line arguments.
Sorry for the delay.
:tada: This PR is included in version 2.8.4 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Thank you! 👏 👏 👏
Get all git differences all at once
Issue #263