search

amtrack / force-dev-tool

[DEPRECATED] Command line tool supporting the Force.com development lifecycle
MIT License
108 stars 37 forks source link

fix: get git diff all at once #265

Closed froucher closed 4 years ago

froucher commented 4 years ago

Get all git differences all at once

Issue #263

froucher commented 4 years ago

Hello @amtrack,

How are you? Maybe it could be helpful to have a session to review this PR. Please let me know if it is interesting from you side.

Regards and thank you

amtrack commented 4 years ago

Hello @amtrack,

How are you? Maybe it could be helpful to have a session to review this PR. Please let me know if it is interesting from you side.

Regards and thank you

@froucher Thanks, I'm doing well. Yes, let's do a session. I'll contact you via email regarding an appointment.

amtrack commented 4 years ago

@froucher I have one minor change request, besides that this PR looks good to me.

Apparently the metadataContainer constructed in these lines isn't used anymore by your implementation, so that explicitly creating changesets using command line arguments (e.g. force-dev-tool changeset create mytestclass ApexClass/FooTest) doesn't work anymore. I've now relocated the corresponding test from test-integration to test (#267) so that it is run in CI for Pull Requests.

Can you please rebase your PR to latest master branch and try to integrate the metadataContainer instance again?

froucher commented 4 years ago

Hi,

Done, it fails...

A previous question, when I wanted to create a changeset with one file, I usually executed a command like:

git diff master..HEAD -- ApexClass/FooTest | force-dev-tool changeset create mytestclass

Maybe this workaround could replace the functionality.

Anyway, for backward compatibility, I will review the source code to understand why is not supported.

Thanks.

froucher commented 4 years ago

Hi @amtrack,

I resolved the issue about explicitly creating changeset using command line arguments.

Sorry for the delay.

amtrack commented 4 years ago

:tada: This PR is included in version 2.8.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

froucher commented 4 years ago

Thank you! 👏 👏 👏