search

amueller / gco_python

Python wrappers for GCO alpha-expansion and alpha-beta-swaps
137 stars 65 forks source link

update setup #17

Closed Borda closed 6 years ago

Borda commented 6 years ago

Hello, may I have a friendly advice for the setup, you should include also setup require since it may fail while installing to empty environment, you can take an inspiration from the alternative GCO wrapper.

amueller commented 6 years ago

PR welcome ;)

amueller commented 6 years ago

Why did you rewrite the wrappers? Don't you like OpenGM2?

Borda commented 6 years ago

I did not rewrite it, I just adopt it (the rewriting job was done by someone else) and made some particular changes such as the setup, tests, etc. :)

amueller commented 6 years ago

Hey. Sorry I didn't follow up. Maybe we should try merging these projects?

Borda commented 6 years ago

Well, I think that it would be nice to have only one wrapper for the GCO so a user does not need to think much which one to chose or try as first one... I see that for this wrapper there are still a few todos compare to the other wrapper which seems to be complete... on the other hand, I am not the owner of the other one so a merging is not up to me to make such decision...