amueller / introduction_to_ml_with_python

Notebooks and code for the book "Introduction to Machine Learning with Python"
7.45k stars 4.57k forks source link

mglearn/load_boston issue #183

Closed epakhomov closed 8 months ago

epakhomov commented 8 months ago

It's March 2024 and the mglearn still errors out because of the boston data set. It is not cool to sell not very cheap book like this. It has less value with the broken code. Degrading libraries is also not a good solution.

wanghedy commented 8 months ago

您的邮件已收到,我将会尽快处理,谢谢。王宇凝

amueller commented 8 months ago

Can you provide error? This should have been fixed in current mglearn. what version of mglearn are you using? I understand this can be quite frustrating, though it's hard to keep a book up-to-date with changing libraries over many years.

epakhomov commented 8 months ago

@amueller version is 0.2.0. I installed it today with pip install mglearn. The error enclosed. Thanks! error.txt

amueller commented 8 months ago

Looks like I didn't update the version of mglearn in this repository, and you're using the one from this repository that you checked out with the notebooks, not the pip installed version. This duplication is a bit unfortunate, I was hoping it'll help people that are not familiar with the pretty confusing python packaging systems. If you delete the mglearn folder within your working directory, it should work. I'll update the package that's included in the repo now, so updating the repo afterwards should also work.

amueller commented 8 months ago

ok, this repo is now also updated. Let me know if you get it to work.

epakhomov commented 8 months ago

@amueller everything works now. Appreciate the quick response. Thanks!