amueller / mglearn

mglearn helper package for "Introduction to Machine Learning with Python"
230 stars 116 forks source link

DeprecationWarning: Function make_blobs is deprecated; Please import make_blobs directly from scikit-learn warnings.warn(msg, category=DeprecationWarning) #14

Closed nicolasplanchon closed 4 years ago

nicolasplanchon commented 5 years ago

Hi there, This issue will be very easy to understand

image

amueller commented 5 years ago

I'm not sure what you are asking. I'm saying that I'm going to be removing this function as it went upstream to sklearn with a slightly different interface. There is no use of this in the book / the notebooks any more.

nicolasplanchon commented 5 years ago

page 40 in the chapter regarding the knn classifier you use it, and it doesn't work that way.

amueller commented 5 years ago

It totally still works. And yes, obviously old printed books still use it because paper doesn't update. Newer prints don't use it. This is just a warning and doesn't change anything.

greennomad424242 commented 5 years ago

Hi. This warning is still present when using code in the Kindle-based version (as of February 2019).

amueller commented 5 years ago

@greennomad424242 what's the code there?

sanghee1021 commented 5 years ago

wow. i had the same issue, but it didn't seem to affect anything but creating a warning sign.