search

amueller / scipy-2016-sklearn

Scikit-learn tutorial at SciPy2016
Creative Commons Zero v1.0 Universal
515 stars 516 forks source link

move feature selection up? #22

Closed amueller closed 8 years ago

amueller commented 8 years ago

Currently feature selection is after a bunch of unsupervised learning. I think it should be together with the supervised learning.

rasbt commented 8 years ago

Haha, sorry for all my counter-arguments in the last 5 minutes ... :P. I actually think that having a separate feature selection notebook may be useful rather ... for clarity and also as a future reference for the attendees. E.g., "How do I do feature selection again, ahja wait, we had this notebook here ... "

amueller commented 8 years ago

I didn't mean remove the notebook. I meant reorganize the toc. I think it would make more sense after 24 rather than after 26

rasbt commented 8 years ago

Oh okay, with that I agree! :) I thought you meant merging the content of the notebook into the other one ... Okay, then let me merge your pull requests first ...

amueller commented 8 years ago

done in 2d83abbeaf89a9540540ef71e2ecf6bef5adb982