Closed darkaico closed 1 year ago
Thank you! Overall looks good but I'm confused that CI is not running. was the whitespace change in the yaml necessary?
[edit] Hm looks like the change is actually good. Not sure what's going on there.
I'm sorry, there was an issue with the actions setup. can you please merge master into the PR?
I'm sorry, there was an issue with the actions setup. can you please merge master into the PR?
thanks for checking! I just rebased the branch with the latest master
@amueller pinging you again in case you missed the update 😃
@darkaico Thanks for the PR. @amueller Is there any chance that you merge this PR anytime soon?
Any chance at a timetable for merger? @amueller
sorry for the delay. I'm surprised the CI still didn't kick off... I'm not sure what's happening there.
Thank you for adding 3.11 support! Any chance of cutting a release with the fix soonish? People are failing to install the latest release on 3.11 (cf. linked issues above). The readme says that the code is tested against 3.11, which of course by no means implies that the latest release installs on 3.11, technically, but it does set up an expectation that it should work.
I see the support for python 3.11 is added in the PR to master. But pip install still doesn't pull the latest changes. pip install is still failing for python 3.11, so any tentative date for the next release with the fix?
@amueller it would be helpful to many if we have a release soon with the python 3.11 support.
Sorry for the slow response, there were a lot of issues on this. I shipped a release in April.
Apparently, it didn't work. I'm on debian 12, attempting to build wordcloud 1.8.1 as part of a dependencies requirement.
I get the usual stream of error text:
Running setup.py install for wordcloud ... error
error: subprocess-exited-with-error
× Running setup.py install for wordcloud did not run successfully.
│ exit code: 1
╰─> [29 lines of output]
running install
/home/goon/python.prj/python3.11.2-venv/lib/python3.11/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
warnings.warn(
running build
running build_py
creating build
creating build/lib.linux-x86_64-cpython-311
creating build/lib.linux-x86_64-cpython-311/wordcloud
copying wordcloud/init.py -> build/lib.linux-x86_64-cpython-311/wordcloud
copying wordcloud/tokenization.py -> build/lib.linux-x86_64-cpython-311/wordcloud
copying wordcloud/_version.py -> build/lib.linux-x86_64-cpython-311/wordcloud
copying wordcloud/color_from_image.py -> build/lib.linux-x86_64-cpython-311/wordcloud
copying wordcloud/main.py -> build/lib.linux-x86_64-cpython-311/wordcloud
copying wordcloud/wordcloud_cli.py -> build/lib.linux-x86_64-cpython-311/wordcloud
copying wordcloud/wordcloud.py -> build/lib.linux-x86_64-cpython-311/wordcloud
copying wordcloud/stopwords -> build/lib.linux-x86_64-cpython-311/wordcloud
copying wordcloud/DroidSansMono.ttf -> build/lib.linux-x86_64-cpython-311/wordcloud
UPDATING build/lib.linux-x86_64-cpython-311/wordcloud/_version.py
set build/lib.linux-x86_64-cpython-311/wordcloud/_version.py to '1.8.1'
running build_ext
building 'wordcloud.query_integral_image' extension
creating build/temp.linux-x86_64-cpython-311
creating build/temp.linux-x86_64-cpython-311/wordcloud
x86_64-linux-gnu-gcc -Wsign-compare -DNDEBUG -g -fwrapv -O2 -Wall -g -fstack-protector-strong -Wformat -Werror=format-security -g -fwrapv -O2 -I/include/python3.11/cpython -fPIC -I/home/goon/python.prj/python3.11.2-venv/include -I/usr/include/python3.11 -c wordcloud/query_integral_image.c -o build/temp.linux-x86_64-cpython-311/wordcloud/query_integral_image.o
wordcloud/query_integral_image.c:196:12: fatal error: longintrepr.h: No such file or directory
196 | #include "longintrepr.h"
| ^~~~~~~
compilation terminated.
error: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1
[end of output]
note: This error originates from a subprocess, and is likely not a problem with pip. error: legacy-install-failure
× Encountered error while trying to install package. ╰─> wordcloud
note: This is an issue with the package mentioned above, not pip.
Fixes amueller/word_cloud/issues/691
query_integral_image
with the latest Cython