amugofjava / anytime_podcast_player

Simple, easy to use Podcast player app written in Flutter and Dart.
BSD 3-Clause "New" or "Revised" License
376 stars 99 forks source link

Podcast description text block is not anchored to its parent #124

Closed amugofjava closed 2 months ago

amugofjava commented 2 months ago

Describe the bug The podcast details page shows the podcast description, which can be expanded or collapsed if necessary; however, the text block is not anchored to the top of its parent, so the margin at the top of the text block can vary between podcasts. This is particularly noticeable at lower resolutions.

To Reproduce Steps to reproduce the behavior:

  1. Open a podcast.
  2. Open a second, third etc and see the margin at the top of the text block change.

Expected behavior The text block should be anchored to the top of its parent to keep the margin and padding consistent.

Screenshots

Example image 2

filip-alexandrov commented 2 months ago

As I understand, the margin above the description text is part of the HTML renderer itself. Most show descriptions are in plain text (as opposed to episode descriptions). HTML and plain text are prestyled differently.

2 5 Admins - plain

Add to playlist - html

Here "Add to playlist" has wrapped its description inside p tag. There is added vertical margin to p tags by default. On the contrary, "2.5 Admins" has plain-text description and the absense of a p tag can be seen in the reduced margin above the text field.

Fixing this will require setting p tag margins to 0, but there can be other tags with default styling like h1 title tags. I have rarely seen tags other than p in the show description. I will include a fix in #123