search

amugofjava / anytime_podcast_player

Simple, easy to use Podcast player app written in Flutter and Dart.
BSD 3-Clause "New" or "Revised" License
403 stars 101 forks source link

Chapter placeholder image can flash when no connection #57

Closed amugofjava closed 2 years ago

amugofjava commented 3 years ago

Describe the bug Playing a downloaded episode containing chapters with separate chapter art can result in the placeholder image flashing when offline.

To Reproduce Steps to reproduce the behavior:

  1. Download a podcast which you know contains Podcasting 2.0 chapters with chapter art.
  2. Enable airplaine mode.
  3. Open the main player, switch to a chapter containing chapter art.
  4. Switch back to details tab. The Anytime logo placeholder will flash.

Expected behavior It should show a solid placeholder image.

Additional context The issue seems to be with the image library attempting to fetch the image and repeatedly switching between success and failure state resulting in the placeholder image appearing and then being removed. The image library needs to consistently return an error state if the image cannot be fetched.

amugofjava commented 2 years ago

Fixed in feature branch. Testing before merging into master.