search

amugofjava / podcast_search

A simple library providing programmatic access to the iTunes search API for podcasts.
MIT License
41 stars 26 forks source link

Upgrade to dart 3 and use rss_dart #14

Closed Feichtmeier closed 1 year ago

Feichtmeier commented 1 year ago

Hoi :wave:

This PR upgrades the version constraints of the dart sdk to '>=3.0.0 <4.0.0' which needs our fork of dart_rss, named rss_dart

I also fixed a NPE.

Feichtmeier commented 1 year ago

hmmmm testing this branch in musicpod right now... and all titles are empty :thinking:

amugofjava commented 1 year ago

That's odd. When you search for a podcast, are all the fields populated - such as image url etc?

Feichtmeier commented 1 year ago

could totally be in the weird process of copying and dirty fixing dart rss that something got f*cked up. I think I need to investigate in rss_dart first before I finish this PR here.

Feichtmeier commented 1 year ago

@amugofjava okay found the issue....I rss.dart I replaced all occurences of text with value which is wrong. I needed to replace it because text was no longer used but the replacement is innerText and not value :facepalm: Will fix and make a new release then come back to this PR

Feichtmeier commented 1 year ago

Okay it works again :+1:

amugofjava commented 1 year ago

Thanks for the update. I'm trying to get the next release of Anytime out. Once that is done I'll be able to devote some time to podcast_search and rss-dart