search

amugofjava / podcast_search

A simple library providing programmatic access to the iTunes search API for podcasts.
MIT License
41 stars 26 forks source link

Support podcast index 2.0 value tag #4

Closed roeierez closed 3 years ago

roeierez commented 3 years ago

This PR adds the "value" tag to podcast item search result as specified by podcast index 2.0 schema (https://github.com/Podcastindex-org/podcast-namespace). The value tag defines the payment model of the item and supports lightning payments. In addition I have modified the _buildSearchUrl method of PodcastIndexSearch to buildSearchUrl so it can be reused by only changing the url and demonstrated a way to use a custom search provider via a unit test. The option of custom search provider is useful when the caller wants to use different API endpoints to search using podcast index and my intention is to use such custom provider when using anytime podcast app as a dependency inside Breez while I am avoiding significant changes to the low level library.

roeierez commented 3 years ago

Closing this PR as we don't need the tag support at the search level for now, we need that when loading the feed.

amugofjava commented 3 years ago

OK thanks @roeierez. Looking at the spec, the value tag is part of phase 3. How soon do you think you'll need to read the value tag in the rss?

roeierez commented 3 years ago

OK thanks @roeierez. Looking at the spec, the value tag is part of phase 3. How soon do you think you'll need to read the value tag in the rss?

Hi @amugofjava Actually we need it right away (It is the only tag we actually need) and the problem is that it is only well supported via the json API. We can discuss on telegram on how to proceed.