amule-project / amule

'All-platform' P2P client based on eMule
982 stars 218 forks source link

aMule does not support HTTPS #197

Open IAmTheNail opened 4 years ago

IAmTheNail commented 4 years ago

For some time now I'm getting this error message whenever amule needs an http connection. As of now it is unable to download any update, server list, ...

It happens with 2.3.2-2 release for ubuntu. Building from source yields the same results.

The error message is raised in HTTPDownload.cpp, line 336

if (!location.StartsWith(wxT("http://"))) {
        // This is not a http url
        throw wxString(_("Invalid URL for HTTP download or HTTP redirection (did you forget 'http://' ?)"));
}

It seems wxT("http://") doesn't result in "http://" anymore. No doubt because of something I did recently on the system. However, I have been unable to find the culprit. Neither can I suggest a workaround because I am not proficient in C++ and the related toolkits.

Btw, is there a special reason to use http only ? That is, not using https.

IAmTheNail commented 4 years ago

Is it possible amule does not support http redirection ?

.2020-06-07 15:07:18: HTTPDownload.cpp(196): HTTP: HTTP download thread started .2020-06-07 15:07:18: HTTPDownload.cpp(220): HTTP: If-Modified-Since: Sat, 30 May 2020 18:40:28 GMT 2020-06-07 15:07:18: ServerConnect.cpp(201): Connected to eMule Security (80.208.228.241:8369) .2020-06-07 15:07:18: HTTPDownload.cpp(392): HTTP: Host: upd.emule-security.org:80 .2020-06-07 15:07:18: HTTPDownload.cpp(393): HTTP: URL: http://upd.emule-security.org/ipfilter.zip .2020-06-07 15:07:18: HTTPDownload.cpp(394): HTTP: Response: 301 (Error: 0) .2020-06-07 15:07:18: HTTPDownload.cpp(304): HTTP: HTTP download thread ended !2020-06-07 15:07:18: HTTPDownload.cpp(292): Invalid URL for HTTP download or HTTP redirection (did you forget 'http://' ?)

gonosztopi commented 4 years ago

Is it possible amule does not support http redirection ?

It's aMule not supporting HTTPS. The old HTTP URL is now getting redirected to a HTTPS URL, which is not supported (yet).