[cmake] Programs installed iwthout executable bits

amule-project / amule

'All-platform' P2P client based on eMule

1.01k stars 221 forks source link

[cmake] Programs installed iwthout executable bits #272

Closed lgbaldoni closed 3 years ago

lgbaldoni commented 3 years ago

Shouldn't: https://github.com/amule-project/amule/blob/master/src/utils/xas/CMakeLists.txt#L6 and https://github.com/amule-project/amule/blob/master/src/utils/xas/CMakeLists.txt#L10 contain install(PROGRAMSinstead?

Vollstrecker commented 3 years ago

For the second one yes. The other one is the plugin that get called with the interpreter from XChat, doesn't make sense to call it by hand.

lgbaldoni commented 3 years ago

Does xas.pl need a shebang then?

Vollstrecker commented 3 years ago

I guess no, but I'm not the author. This piece is now 17 years old and I hardly doubt anyone is still using it. X-Chat 2 is dead, there was a replacement called hexchat, it's last release is older than our's, and maybe it was never tested with this.