api-changes in upnp - Githubissues

Vollstrecker commented 3 years ago

amule fails compile against latest libupnp

/home/runner/work/amule/amule/src/UPnPBase.cpp:447:16: error: cannot convert ‘const char*’ to ‘UpnpLib*’ {aka ‘s_UpnpLib*’}
  447 |   URLBase.c_str(),
      |   ~~~~~~~~~~~~~^~
      |                |
      |                const char*
In file included from /home/runner/work/amule/amule/src/UPnPCompatibility.h:32,
                 from /home/runner/work/amule/amule/src/UPnPBase.h:36,
                 from /home/runner/work/amule/amule/src/UPnPBase.cpp:36:
/home/runner/work/amule/amule/build/_deps/pupnp-src/upnp/inc/upnptools.h:89:18: note:   initializing argument 1 of ‘int UpnpResolveURL(UpnpLib*, const char*, const char*, char*)’
   89 |         UpnpLib *p,
      |         ~~~~~~~~~^

And so on... I think this time a version-switch is needed to support old and new interface. Luckily the version is defined in upnpconfig.h

mrjimenez commented 3 years ago

Hi,

Don't compile against master for now. 1.14.x is the current release. I still don't know if those API changes will hold.

Cheers!

Vollstrecker commented 3 years ago

Sure, but somewhen the API will be finished, and that way it isn't forgotten.

amule-project / amule

api-changes in upnp #274