amule-project / amule

'All-platform' P2P client based on eMule
994 stars 218 forks source link

Support for wxwidgets3.2 #340

Open sandrotosi opened 2 years ago

sandrotosi commented 2 years ago

Hello, in debian we're planning on moving away from wxwidgets3.0 and to wxwidgets3.2 in the upcoming release, see http://bugs.debian.org/1019841

It looks like an initial attempt to build amule with 3.2 was done in fedora: https://pkgs.rpmfusion.org/cgit/free/amule.git/commit/?id=e13689d65ff6d1ca6f563226a2e1b95ea0259452 but it was also quickly reverted: https://pkgs.rpmfusion.org/cgit/free/amule.git/commit/?id=bc4e4fedcb425fa2efa951e08dbaed891d380462

Do you plan on support 3.2 (hopefully in an upcoming amule release :) )?

Vollstrecker commented 2 years ago

I don't think there are real plans at all atm. After cmake integration is done, I'm planning to try this (or maybe split generic and wx-stuff and add some qt), but I wouldn't hold my breath for it.

sandrotosi commented 2 years ago

thanks for getting back to me!

I don't think there are real plans at all atm. After cmake integration is done,

i feel that's been in the work for quite some time, are we close to merge it?

I'm planning to try this (or maybe split generic and wx-stuff and add some qt), but I wouldn't hold my breath for it.

that's a bit of an issue, given it may mean amule will get removed from debian if not compatible with wxWidget 3.12. i was pointed to https://github.com/amule-project/amule/pull/168 but i'm not sure it's sufficient

mifritscher commented 1 year ago

Debian applied a cleaned up version of the patch and applied it to sid - for details, see the bug report link at the top. Not sure if it gets an exception for migrating back to testing (=bookworm). I've uploaded the patch (not from me ;) ) and the deb packages here: https://mifritscher.de/austausch/debian-bookworm/amule/ .

sandrotosi commented 1 year ago

Debian applied a cleaned up version of the patch and applied it to sid - for details, see the bug report link at the top. Not sure if it gets an exception for migrating back to testing (=bookworm). I've uploaded the patch (not from me ;) ) and the deb packages here: https://mifritscher.de/austausch/debian-bookworm/amule/ .

and why not point to the actual debian packaging repository here and the wx porting patch here instead of your personal/unofficial repo?

mifritscher commented 1 year ago

and why not point to the actual debian packaging repository here and the wx porting patch here instead of your personal/unofficial repo?

Regarding the first link: Somehow I don't see the deb-files at your first link? The rationale of publishing these files is to have them even when sid goes forward and the deb-files in sid are not compatible with bookworm anymore.

Regarding the second: Mixture of time problem (this wasn't here when I tested the patch) and didn't see this yesterday ;-)

mifritscher commented 1 year ago

As you seem to be the maintainer for the debian packages: https://tracker.debian.org/pkg/amule reveals that the only reason left not to be in testing is the freeze: Is there any chance to get an approval to let it slip into testing again, as it is not a "core" package? I'm more than happy to kill my personal "repo" if it included into testing again (or bookworm-backports) :-)

sandrotosi commented 1 year ago

As you seem to be the maintainer for the debian packages: https://tracker.debian.org/pkg/amule reveals that the only reason left not to be in testing is the freeze: Is there any chance to get an approval to let it slip into testing again, as it is not a "core" package? I'm more than happy to kill my personal "repo" if it included into testing again (or bookworm-backports) :-)

good point, opened http://bugs.debian.org/1033375

mifritscher commented 1 year ago

Thanks you very much! As it is in bookworm now, I killed my repo with an hint "These are now on the official debian bookworm (testing) repository. " :-)

sl1pkn07 commented 9 months ago

amuled (daemon) crash a lot with debian patch and wx3.2.4 i paste te output here https://github.com/amule-project/amule/pull/168

any chance for update the patch for fix the issue?

greetings