search

amulyakhare / TextDrawable

This light-weight library provides images with letter/text like the Gmail app. It extends the Drawable class thus can be used with existing/custom/network ImageView classes. Also included is a fluent interface for creating drawables and a customizable ColorGenerator.
MIT License
3.16k stars 623 forks source link

Using AAR from gradle overrides app launcher icons #3

Closed pulimento closed 9 years ago

pulimento commented 9 years ago

When using as a BinTray dependency in Android Studio v1.0.1, app gets its main icon (ic_launcher) from this library instead of app's default icon. This results in app appearing with android-robot default icon.

I've found posts in StackOverflow regarding this issue, but proposed solutions not worked from me.

Please, remove ic_launcher icons from the generated AAR library. Thanks

jenzz commented 9 years ago

This is annoying indeed.

@amulyakhare, can you please kill the ic_launcher.png drawables?

They aren't required anyway...

saket commented 9 years ago

Looks like @amulyakhare has abandoned his project :(

jenzz commented 9 years ago

I forked this repo and fixed the issue by removing all the ic_launcher drawables.

I don't wanna steel any glory from the author but I've built the .aar file for this library and uploaded it to my local maven repo here on GitHub. Once this library has the issue fixed or if the author will ask me to I will erase the library from my repo right away.

If you wanna use it, you can include it like this:

repositories {
    ...
    maven { url 'https://github.com/jenzz/jenzz-mvn-repo/raw/master/releases' }
}

dependencies {
    ...
    compile 'com.amulyakhare:com.amulyakhare.textdrawable:1.0.0'
}
pulimento commented 9 years ago

Thanks! @amulyakhare i'm closing this issue now

amulyakhare commented 9 years ago

Hi guys,

I am sorry that I have not been able to maintain this project for some time now. I was extremely busy with something else. I have uploaded a new version of the .aar. Will try my best to keep things updated in the future.

Regards, -Amulya