amundsen-io / amundsen

Amundsen is a metadata driven application for improving the productivity of data analysts, data scientists and engineers when interacting with data.
https://www.amundsen.io/amundsen/
Apache License 2.0
4.39k stars 955 forks source link

Fix: Enable neptune proxy custom sts endpoint #2086

Closed loojovi closed 1 year ago

loojovi commented 1 year ago

Summary of Changes

Currently, when users deploy Amundsen with Neptune backend DB, NeptuneBulkLoaderApi is instantiated with the default STS endpoint.

However, this might not work when users deploy the service in government cloud / regional cloud, and the default endpoint is disabled. This PR allows user to specify the STS endpoint in the metadata config file, if they wish to.

Tests

No tests added because it does not change any application behavior. It only creates an option for user to specify their STS endpoint upfront in the config file.

Documentation

Added a line in docs/tutorials/how-to-use-amundsen-with-aws-neptune.md to explain that users can now specify STS endpoint.

CheckList

Make sure you have checked all steps below to ensure a timely review.