Fix: Add rds badge association records - Githubissues

amundsen-io / amundsen

Amundsen is a metadata driven application for improving the productivity of data analysts, data scientists and engineers when interacting with data.

https://www.amundsen.io/amundsen/

Apache License 2.0

4.37k stars 953 forks source link

Fix: Add rds badge association records #2179

Closed sahithi03 closed 1 year ago

sahithi03 commented 1 year ago

Description

This PR creates a rds table_badge association record when creating a record iterator.

Motivation and Context

Currently while creating a badge record a table_badge association record is not created. This only adds badges in the 'badge' table in MySql and hence the badges are not visible for each table on the UI when using csvTableBadgeExtractor https://github.com/amundsen-io/amundsen/blob/main/databuilder/databuilder/extractor/csv_extractor.py#L80.

How Has This Been Tested?

Tested changes using csvTableBadgeExtractor and sample table and badge csv files.

Documentation

CheckList

[ ] PR title addresses the issue accurately and concisely
[ ] Updates Documentation and Docstrings
[ ] Adds tests
[ ] Adds instrumentation (logs, or UI events)

sahithi03 commented 1 year ago

Hi @feng-tao Could you please review this PR when you get a chance? Thanks!