amundsen-io / amundsen

Amundsen is a metadata driven application for improving the productivity of data analysts, data scientists and engineers when interacting with data.
https://www.amundsen.io/amundsen/
Apache License 2.0
4.4k stars 955 forks source link

feat: Make sqlalchemy_extractor compatible with sqlalchemy>=1.4 #2209

Closed mikekutzma closed 10 months ago

mikekutzma commented 10 months ago

feat: Make sqlalchemy_extractor compatible with sqlalchemy>=1.4

Description

These changes to the sql_alchemy_extractor module allow for using the extractors with updated versions of sqlalchemy.

Motivation and Context

This addresses issues such as

How Has This Been Tested?

Tested using sampple_mssql_metadata.py script for

Documentation

None

CheckList

boring-cyborg[bot] commented 10 months ago

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

Golodhros commented 10 months ago

Please rebase with master to fix the checks!

mikekutzma commented 10 months ago

Moved to #2213