amundsen-io / amundsen

Amundsen is a metadata driven application for improving the productivity of data analysts, data scientists and engineers when interacting with data.
https://www.amundsen.io/amundsen/
Apache License 2.0
4.34k stars 950 forks source link

Dynamic notices fix for table detail page #2210

Closed mikaalanwar closed 8 months ago

mikaalanwar commented 8 months ago

Fix - This PR fixes the following issues in Amundsen:

Description

This PR updates the table detail page to initiate a new request for the Notice API every time we transition over from the "TableDetailPage" over to the "TableDetailPage" for a different table. Furthermore, it makes use of the isLoadingNotices flag to hide stale / previously loaded values from the component while a new one is being fetched via the Notice API.

Motivation and Context

Issue # 2204 and Issue # 2205 prevented us from using a critical feature and depreciated the overall user experience of our users. This change helps address those issues.

How Has This Been Tested?

This has been tested locally as well as on the staging environment.

Documentation

The documentation did not require any further changes, beyond what's already mentioned.

CheckList

Golodhros commented 8 months ago

Please rebase with master to fix the checks!