Closed jdslaugh closed 4 months ago
Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)
Maybe I would add a count on the aggregated notices, something like a (X) at the end of the text.
the feature looks great!
Maybe I would add a count on the aggregated notices, something like a (X) at the end of the text.
Ooh that's a good idea, yeah I can do that!
Awesome work, congrats on your first merged pull request!
Description
Aggregates alert notices that are passed into the AlertList component and then parses them in the DefinitionList.
Motivation and Context
The UI is cluttered when there are numerous alerts taking up space, especially when many of them have the same title. Aggregating them into one modal alleviates this and reduces the visual strain on the user.
Screenshots (Before)
Notices
Modal
Info SVG Icon Alignment
Screenshots (After)
Notices
Modal
Storybook
Info SVG Icon Alignment
How Has This Been Tested?
CheckList