amundsen-io / amundsen

Amundsen is a metadata driven application for improving the productivity of data analysts, data scientists and engineers when interacting with data.
https://www.amundsen.io/amundsen/
Apache License 2.0
4.34k stars 950 forks source link

feat: Aggregating Alerts Feature #2230

Closed jdslaugh closed 4 months ago

jdslaugh commented 5 months ago

Description

Aggregates alert notices that are passed into the AlertList component and then parses them in the DefinitionList.

Motivation and Context

The UI is cluttered when there are numerous alerts taking up space, especially when many of them have the same title. Aggregating them into one modal alleviates this and reduces the visual strain on the user.

Screenshots (Before)

Notices

Screenshot 2024-02-09 at 3 20 46 PM

Modal

Screenshot 2024-02-09 at 3 20 51 PM

Info SVG Icon Alignment

Screenshot 2024-02-23 at 12 51 57 PM

Screenshots (After)

Notices

Screenshot 2024-02-23 at 12 56 24 PM

Modal

Screenshot 2024-02-09 at 3 18 18 PM

Storybook

Screenshot 2024-02-09 at 3 41 36 PM

Info SVG Icon Alignment

Screenshot 2024-02-23 at 12 56 24 PM

How Has This Been Tested?

CheckList

boring-cyborg[bot] commented 5 months ago

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

Golodhros commented 5 months ago

Maybe I would add a count on the aggregated notices, something like a (X) at the end of the text.

feng-tao commented 4 months ago

the feature looks great!

jdslaugh commented 4 months ago

Maybe I would add a count on the aggregated notices, something like a (X) at the end of the text.

Ooh that's a good idea, yeah I can do that!

boring-cyborg[bot] commented 4 months ago

Awesome work, congrats on your first merged pull request!