search

amundsen-io / amundsen

Amundsen is a metadata driven application for improving the productivity of data analysts, data scientists and engineers when interacting with data.
https://www.amundsen.io/amundsen/
Apache License 2.0
4.34k stars 950 forks source link

fix: Update mssql extractor to utilize proper case for case sensitive MSSQL databases #2234

Open ardcarmvk opened 4 months ago

ardcarmvk commented 4 months ago

Correct SQL code's table and column case so mssql extractor works with case sensitive instances

Description

Some SQL Server databases are configured as case sensitive. Changes were made for utilizing proper case in required areas.

Motivation and Context

Extractor will not work on mssql databases that are case sensitive

How Has This Been Tested?

Ran the SQL code on SQL database with case sensitivity, tested the extractor against non-case sensitive and case sensitive databases. Ran on windows 10 with python 3.12 on local machine.

Documentation

CheckList

boring-cyborg[bot] commented 4 months ago

Congratulations on your first Pull Request and welcome to Amundsen community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/amundsen-io/amundsen/blob/main/CONTRIBUTING.md)

Golodhros commented 4 months ago

Please check the DCO task above

ardcarmvk commented 4 months ago

DCO task should be resolved now, just need review. Thanks

Golodhros commented 4 months ago

@ardcarmvk it seems it got broken again

kristenarmes commented 4 months ago

@ardcarmvk it seems it got broken again

I think the issue is the original commit has to be modified to include the sign off, check out the details in the failed task here for instructions

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.