amupedia2021 / amupedia-web

Source code of the website.
https://www.amupedia.site/
MIT License
164 stars 178 forks source link

[Bug]: Update the copyright section #235

Closed abhinav-m22 closed 1 year ago

abhinav-m22 commented 1 year ago

Give a brief about the bug discovered✍

In the copyright section of the web page, the year 2021 is hard-coded. It is not the standard way of writing code. Everytime the code will have to be changed for updating the year. Also, the section is not aligned properly.

image

What is the expected behavior?

The web page needs to have a footer with a function that fetches the dynamic value of the current year. The alignment need to be fixed with the CSS.

Give a brief description to get the expect behaviour.

Add a function to dynamically fetch the year from a function which is the best practice to add the copyright to any website to make it look formal.

Are you contributing for a program?

GSSoC2023

Code of Conduct

kinsteve commented 1 year ago

To get the expected behavior I will fetch the current year using new Date().getFullYear() , than changing the html of copyright using span tag and textContent property.

And to perfectly align it , I will have look into its css defined using #ftbg id , I will apply margin:auto to align it horizontaly and align-item : center for vertical alignment.

@abhinav-m22 No I am not A contributor of GSSoC2023 , but Please assign me this issue.

anmode commented 1 year ago

@kinsteve If @abhinav-m22 agree I'll assign this to you! IF he wanna continue then please could you look at other issues

abhinav-m22 commented 1 year ago

@kinstev Please find another issue.. Because I've already started working on this issue

tusharbansal22 commented 1 year ago

But isn't the year in copyright meant to be the year of start of the project @anmode , why do we want it to be the current year?

AmanJain18 commented 1 year ago

@kinstev Please find another issue.. Because I've already started working on this issue

Have u implemented ?

abhinav-m22 commented 1 year ago

Someone already resolved the issue

AmanJain18 commented 1 year ago

Okay, No problem, 😊 Find and work on another issue..

AmanJain18 commented 1 year ago

Remarks: The issue is already fixed..