amupedia2021 / amupedia-web

Source code of the website.
https://www.amupedia.site/
MIT License
162 stars 176 forks source link

[Feature Request] - Accessible social anchor elements inside Footer #262

Closed 0xabdulkhaliq closed 1 year ago

0xabdulkhaliq commented 1 year ago

Is your feature request related to a problem ? Please describe. ✍️

Enhancement:
- The social anchor elements on `footer` in accessible, so users who relay on screen readers may face issues to properly navigate to responsible destination

Describe breifly how would you implement the same.

Solution_steps:
- We can resolve the issue with adding an `aria-label` attribute for those anchor elements
- The aria-label attribute is used to provide a text alternative for an element that is not visible to screen readers. This is important for accessibility, as it allows people who are blind or have low vision to understand the purpose of the element.

Screenshot:

Screenshot 2023-05-27 at 12-27-48 Amupedia From


<a href="https://www.instagram.com/amu.pedia/?hl=am-et" target="_blank" rel="noreferrer">
 <svg>
</a>

To


<a href="https://www.instagram.com/amu.pedia/?hl=am-et"  aria-label="Visit us on Instagram"  target="_blank" rel="noreferrer">
 <svg>
</a>

This snippet aria-label="Visit us on Instagram" is going to be added which improves accessibility of this site


Additional context

Additional context

Are you contributing for a program?

GSSoC2023

Code of Conduct

AmanJain18 commented 1 year ago

Please add a screenshot of what you will implement for better understanding... Re edit Issue...

0xabdulkhaliq commented 1 year ago

Please add a screenshot of what you will implement for better understanding... Re edit Issue...

@AmanJain18, I updated the issue. Currently we can't visually show the changes in screenshot because it's for disabled peoples who relay on screen readers.

Added the snippet which i'm going to add to implement accessiblity you can refer it.

0xabdulkhaliq commented 1 year ago

Pull request has been opened, waiting for your review @AmanJain18 👀

AmanJain18 commented 1 year ago

Pull request has been opened, waiting for your review @AmanJain18 👀

I have checked and suggested changes...