amupedia2021 / amupedia-web

Source code of the website.
https://www.amupedia.site/
MIT License
164 stars 178 forks source link

🐞 [BUG] - All the Contributor are not fetched. #272

Closed kailashchoudhary11 closed 1 year ago

kailashchoudhary11 commented 1 year ago

Description

The currently used GitHub API endpoint returns only the first 30 contributors, not all.

Current behaviour

Only first 30 contributors are visible

Expected behaviour

All the contributors should be visible

Reproduction steps

Go to the contributors page to see this. This repo has 35 contributors but only 30 are listed.

Screenshots

![DESCRIPTION](LINK.png)

Logs

No response

Browsers

No response

OS

No response

Are you contributing for a program ?

GSSoC2023

Code of Conduct

anmode commented 1 year ago

wanna work? I am thinking to consider this too https://github.com/amupedia2021/Project-Amupedia/issues/271

kailashchoudhary11 commented 1 year ago

I'll work on this issue @anmode

kailashchoudhary11 commented 1 year ago

How do you want it to be optimized for #271 ?Like responsiveness or something else?

anmode commented 1 year ago

How do you want it to be optimized for #271 ?Like responsiveness or something else?

reducing the size! it look so larger. and also some UI improvements..

kailashchoudhary11 commented 1 year ago

How do you want it to be optimized for #271 ?Like responsiveness or something else?

reducing the size! it look so larger. and also some UI improvements..

I'm not good at CSS tbh I'll just work on this one.

AmanJain18 commented 1 year ago

How do you want it to be optimized for #271 ?Like responsiveness or something else?

reducing the size! it look so larger. and also some UI improvements..

I'm not good at CSS tbh I'll just work on this one.

Kailas please leave this issue , I will have to fix it inside out, so i will handle it...

kailashchoudhary11 commented 1 year ago

How do you want it to be optimized for #271 ?Like responsiveness or something else?

reducing the size! it look so larger. and also some UI improvements..

I'm not good at CSS tbh I'll just work on this one.

Kailas please leave this issue , I will have to fix it inside out, so i will handle it...

Inside out? I think using https://api.github.com/repos/amupedia2021/Project-Amupedia/contributors?per_page=100 will fix it for now. And I'm planning to add new issue for providing pagination on the contributors page. 🤔

AmanJain18 commented 1 year ago

How do you want it to be optimized for #271 ?Like responsiveness or something else?

reducing the size! it look so larger. and also some UI improvements..

I'm not good at CSS tbh I'll just work on this one.

Kailas please leave this issue , I will have to fix it inside out, so i will handle it...

Inside out? I think using https://api.github.com/repos/amupedia2021/Project-Amupedia/contributors?per_page=100 will fix it for now. And I'm planning to add new issue for providing pagination on the contributors page. 🤔

Do one thing Create an issue for pagination later when i will tell u personally, Because i have to work on UI and some functioning, And will assign u level 3 for pagination, Leave this...for now...

kailashchoudhary11 commented 1 year ago

How do you want it to be optimized for #271 ?Like responsiveness or something else?

reducing the size! it look so larger. and also some UI improvements..

I'm not good at CSS tbh I'll just work on this one.

Kailas please leave this issue , I will have to fix it inside out, so i will handle it...

Inside out? I think using https://api.github.com/repos/amupedia2021/Project-Amupedia/contributors?per_page=100 will fix it for now. And I'm planning to add new issue for providing pagination on the contributors page. 🤔

Do one thing Create an issue for pagination later when i will tell u personally, Because i have to work on UI and some functioning, And will assign u level 3 for pagination, Leave this...for now...

Okay

anmode commented 1 year ago

If we reduce the image size! it would be cool

AmanJain18 commented 1 year ago

Ya will Fix that issue today.✌🏻