amupedia2021 / amupedia-web

Source code of the website.
https://www.amupedia.site/
MIT License
158 stars 175 forks source link

Limited the digit in phone number and blog link added to blog button #322

Closed tanwarAalok closed 1 year ago

tanwarAalok commented 1 year ago

Description

Added maxLength={10} to limit the number of digits that can be entered in Phone number and added blog link to Blogs button present in Home page.

Pull Request Checklist

Please make sure that your PR meets the following requirements:

Checklist

Please check all applicable boxes and provide any additional information if needed.

Screenshots - If Any (Optional)

Additional Notes(Optional)

Please provide any additional information or context that may be helpful for reviewing the pull request.

Related Issues

Please list any related issues or pull requests that are associated with this pull request.

Reviewers

Please tag the relevant team members or reviewers who should review this pull request.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 8:34am
AmanJain18 commented 1 year ago

@tanwarAalok Which issue u are referring ?

tanwarAalok commented 1 year ago

@tanwarAalok Which issue u are referring ?

[BUG] - Want to limit the digits that can be added to phone number in contact us form and provide link of Blogs to Blogs button in Home page #315

Sar-thak-3 commented 1 year ago

Hey @tanwarAalok I think this isn't the way to work under GSSoC or any Open Source event. You first need to be assigned for the issue.

tanwarAalok commented 1 year ago

Hey @tanwarAalok I think this isn't the way to work under GSSoC or any Open Source event. You first need to be assigned for the issue.

So what do I do now close this pull request, and get the issue assigned and then again create PR ?

AmanJain18 commented 1 year ago

Actually got these issue solved in the latest PR

AmanJain18 commented 1 year ago

Issue already got fixed... check pr #335