amupedia2021 / amupedia-web

Source code of the website.
https://www.amupedia.site/
MIT License
163 stars 177 forks source link

Updated Home.module.css to make our services align properly #520

Closed aman-kumar29 closed 1 year ago

aman-kumar29 commented 1 year ago

Description

519

Please provide a brief description of the changes introduced in this pull request. Explain the problem you are solving or the feature you are adding.

Pull Request Checklist

Please make sure that your PR meets the following requirements:

Checklist

Please check all applicable boxes and provide any additional information if needed.

Screenshots - If Any (Optional)

Additional Notes(Optional)

Please provide any additional information or context that may be helpful for reviewing the pull request.

Related Issues

Please list any related issues or pull requests that are associated with this pull request.

Reviewers

Please tag the relevant team members or reviewers who should review this pull request.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 16, 2023 7:24am
github-actions[bot] commented 1 year ago

Thank you, @aman-kumar29, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇 Please make sure you have marked all the completed tasks as done. ✅ We appreciate your patience and contribution! 😀

aman-kumar29 commented 1 year ago

@Harshil-Jani please review it

Harshil-Jani commented 1 year ago

@aman-kumar29 The deployment fails and as I can see you have a syntax error with an extra curly brace on line 80.

aman-kumar29 commented 1 year ago

@Harshil-Jani now it's fine. Can you check once again.

Harshil-Jani commented 1 year ago

@aman-kumar29 I was looking at the deployment and this now looks aligned thanks. But I would like to have 2 things at top level.

  1. Keep the card in row design for desktop screen. Having them in column makes me uncomfortable to scroll through. You can keep a media query from where it was failing.
  2. If I do a view for a certain device, The size of one card feels me odd. Please fix that too. (Refer below screenshot)

image

aman-kumar29 commented 1 year ago

@Harshil-Jani okay I will work on it.

aman-kumar29 commented 1 year ago

@Harshil-Jani I have made the suggested changes now.

anmode commented 1 year ago

please update your branch with develop or master, could you pleaes create a new PR with your changes.. as we recently changes our default branch to develop