amupedia2021 / amupedia-web

Source code of the website.
https://www.amupedia.site/
MIT License
163 stars 177 forks source link

Styles all the blogs #526

Open akanksha984 opened 1 year ago

akanksha984 commented 1 year ago

Description I have styled all the blogs. Issue: https://github.com/amupedia2021/Project-Amupedia/issues/495 image

Pull Request Checklist Please make sure that your PR meets the following requirements:

The app is working correctly after applying the changes. The app is responsive and displays properly on different screen sizes and devices. The changes are thoroughly documented in the appropriate files or documentation sections. The coding conventions and style guidelines are followed consistently. Checklist Please check all applicable boxes and provide any additional information if needed.

[ x] I have tested the changes locally and ensured that the app is functioning as expected. [ x] I have verified that the app is responsive and looks good on various screen sizes and devices. [ x] I have reviewed the documentation and ensured that it accurately reflects the changes made. [ x] I have followed the coding conventions and style guidelines defined in the project. [ x] I have run the automated tests and all of them pass. [ x] I have considered the performance implications of the changes made. [ x] I have considered the security implications of the changes made. [ x] I have checked for any potential regressions or side effects caused by the changes. [ x] I have performed a self-review of my code. [ x] Starred the repository. Added My Name to the Contributor's List. [ x] Followed the repository's Contributing Guidelines. [ x] I ran the app and tested it locally to verify that it works as expected. Screenshots - If Any (Optional) Additional Notes(Optional) Please provide any additional information or context that may be helpful for reviewing the pull request.

Related Issues closed #495 Please list any related issues or pull requests that are associated with this pull request.

Reviewers @Harshil-Jani Please tag the relevant team members or reviewers who should review this pull request.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
project-amupedia ❌ Failed (Inspect) Jul 31, 2023 8:04am
github-actions[bot] commented 1 year ago

Thank you, @akanksha984, for creating this pull request and contributing to GitHub-ReadMe! πŸ’—

Our review team will thoroughly review the pull request and will reach out to you soon! πŸ˜‡ Please make sure you have marked all the completed tasks as done. βœ… We appreciate your patience and contribution! πŸ˜€

akanksha984 commented 1 year ago

Fixed it @Harshil-Jani

akanksha984 commented 1 year ago

@Harshil-Jani sir are the changes up to mark ?

akanksha984 commented 1 year ago

@Harshil-Jani I think it is responsive now please check it

Harshil-Jani commented 1 year ago

@akanksha984 Thanks for the changes. This looks amazing now. There is a shift of branches and we are now accepting changes into the develop branch. I have changed the base branch to develop and it has some conflicts. Can you please resolve the conflicts as a last step and this should be good to be merged. πŸŽ‰

akanksha984 commented 1 year ago

How do we resolve the conflicts, I mean I can see the conflict but what is the conflict and how to fix it please guide @Harshil-Jani

akanksha984 commented 1 year ago

Has it been resolved now @Harshil-Jani I have edited it and then clicked on sign off the commit to main image

Harshil-Jani commented 1 year ago

Hey @akanksha984 I suggest reading

  1. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/about-merge-conflicts
  2. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github (Specially point number 4)

If you are still facing hard time resolving merge conflicts ping me back I can help to do that.

akanksha984 commented 1 year ago

Can you check it now @Harshil-Jani . I think it is fine now.

akanksha984 commented 1 year ago

@Harshil-Jani please review it

Harshil-Jani commented 1 year ago

Hey @akanksha984 I think there is some error. The deployment is failing. Can you try checking and resolving the error on local using yarn build or npm run build ?

akanksha984 commented 1 year ago

@Harshil-Jani please check it now, It should be fine now I hope

Harshil-Jani commented 1 year ago

Hey @akanksha984 For resolving the build errors I see that you removed lazy-loading attributes. We have a PR on this https://github.com/amupedia2021/Project-Amupedia/pull/534. So Can you show us the error? Because I think removing them in order to solve the issues is not a solution until it increases the complexity of the project.

akanksha984 commented 1 year ago

Hey @akanksha984 For resolving the build errors I see that you removed lazy-loading attributes. We have a PR on this #534. So Can you show us the error? Because I think removing them in order to solve the issues is not a solution until it increases the complexity of the project.

I have just pasted the code i had written and it created no issue. Last time there was issue i resolved that still there was error in deployment

akanksha984 commented 1 year ago

@Harshil-Jani can you please help why deployment is failing ?

akanksha984 commented 1 year ago

@Harshil-Jani its working well on local but failing here. If you could help me out it would be great help

akanksha984 commented 1 year ago

@Harshil-Jani @anmode please check it once is it ok now ?

akanksha984 commented 1 year ago

@anmode please look into it