amupedia2021 / amupedia-web

Source code of the website.
https://www.amupedia.site/
MIT License
163 stars 177 forks source link

Our service aligned properly #543

Open aman-kumar29 opened 1 year ago

aman-kumar29 commented 1 year ago

Description

519

Made changes in Home_Module.css file and made the alignment of the our services setion proper and responsive.

Pull Request Checklist

Please make sure that your PR meets the following requirements:

Checklist

Please check all applicable boxes and provide any additional information if needed.

Screenshots - If Any (Optional)

Additional Notes(Optional)

Please provide any additional information or context that may be helpful for reviewing the pull request.

Related Issues

Please list any related issues or pull requests that are associated with this pull request.

Reviewers

Please tag the relevant team members or reviewers who should review this pull request.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview Jul 17, 2023 3:13pm
github-actions[bot] commented 1 year ago

Thank you, @aman-kumar29, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇 Please make sure you have marked all the completed tasks as done. ✅ We appreciate your patience and contribution! 😀

aman-kumar29 commented 1 year ago

@anmode I have created pr with develop branch as suggested. Kindly go through it.

Harshil-Jani commented 1 year ago

@aman-kumar29 Thanks for the contribution. But I would prefer this PR to be on hold for sometime. Reason is complex that we had some different code which had some issues with mobile view and thus we reverted a PR which affected. So with that if you check current HEAD of develop branch then it does not consist of the Boxes on top of Our Services cards. Which means we may not actually need resizing on top of that. Extremely sorry for the confusion tho.

Currently in your preview it is looking really nice but if you would rebase on top of develop branch then you would probably see what I am saying about.