amupedia2021 / amupedia-web

Source code of the website.
https://www.amupedia.site/
MIT License
163 stars 177 forks source link

Contact form submission error fixed #576

Open BhavinRaichura opened 1 year ago

BhavinRaichura commented 1 year ago

Description

This pull request addresses the following issues:

  1. Fixed a bug in the form validation code within the form submit handler of the contact form. The bug was causing the form validation process to malfunction, leading to unsuccessful form submissions. This fix ensures that the form validation works correctly, allowing successful form submissions.
  2. Resolved a bug in the API that was not working as expected. The API is now fixed and functioning properly, ensuring that requests to the API return the expected responses.

Pull Request Checklist

Please make sure that your PR meets the following requirements:

Checklist

Please check all applicable boxes and provide any additional information if needed.

Screenshots - If Any (Optional)

contact form successful submission message Response in console

Additional Notes(Optional)

  1. [x] Fixed a bug in the form validation code within the form submit handler of the contact form.

    • [x] The form validation process was malfunctioning, causing unsuccessful form submissions.
    • [x] The fix ensures that the form validation works correctly, allowing successful form submissions.
    1. [x] Resolved a bug in the API that was not working as expected.
    • [x] The API was fixed and is now functioning properly.
    • [x] Requests to the API now return the expected responses.
  2. [x] Appropriate notification for each type of response in the form

  3. [x] Tested the changes locally to ensure the app is functioning as expected.

    • [x] Verified that the app works without any issues after applying the fixes.

Related Issues

[BUG] -Error submitting contact form #565

Reviewers

@tech-bash

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2023 9:24am
github-actions[bot] commented 1 year ago

Thank you, @BhavinRaichura, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇 Please make sure you have marked all the completed tasks as done. ✅ We appreciate your patience and contribution! 😀

tech-bash commented 1 year ago

Great work! But instead of prepending a notification image maybe you can have a checked image. And try to make the UI kind of like more mature .. Rest all looks fine. Thank you!

BhavinRaichura commented 1 year ago

Sure I will