search

amusecode / amuse

Astrophysical Multipurpose Software Environment. This is the main repository for AMUSE
http://www.amusecode.org
Apache License 2.0
152 stars 98 forks source link

Update rebound interface to Rebound release version 4.0.1 #1019

Open rieder opened 7 months ago

rieder commented 7 months ago

The Rebound version currently in AMUSE is quite old - this updates it to the latest release. The current tests for the rebound interface still work, but should probably be extended.

rieder commented 7 months ago

It needs more extensive testing. Some features seem to work but on closer inspection require some settings to be changed, not all of which are available through the interface.

LourensVeen commented 7 months ago

Hm, so I was early. Should there be some kind of norm for this? When is a code integrated well enough that the PR adding it can be merged? That would then set some standards for reviews. All assuming that we're rich enough to be able to afford these kinds of things of course...

rieder commented 7 months ago

I think in principle it can be merged (since it passes all current tests).

However, since the new version of Rebound adds features, these need to be tested as well. So ideally we want some covering check as well, to make sure the tests don't become meaningless.

LourensVeen commented 7 months ago

That makes sense.

rieder commented 7 months ago

Rebound should probably have a second worker built - one with, and one without OpenMP support. For the whfast integrator (which is in turn used by some other integrators), behaviour is different depending on whether OpenMP is used. In the OpenMP case, it needs a different coordinate system (which is not available through the AMUSE interface yet, and I need to check whether it would make sense to have this available at all).

stale[bot] commented 5 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.