search

amusecode / amuse

Astrophysical Multipurpose Software Environment. This is the main repository for AMUSE
http://www.amusecode.org
Apache License 2.0
155 stars 98 forks source link

Update ci.yml #1045

Open rieder opened 5 months ago

rieder commented 5 months ago

Nice, but we should probably pick one tool and not run two, as they may end up fighting each other. Also, possibly ruff should be under consideration too?

yes we should decide which tool(s) we would want. black and flake8 don't do exactly the same thing, so for checks we may want to use both. Or ruff, I'll have a look at that too.

rieder commented 5 months ago

@LourensVeen I'm not sure how to test the auto-fix part of this, do you have any ideas for that?

rieder commented 4 months ago

I've tested it on a different repository now. The linter will push a fix to the branch in the PR, which seems fine to me.

rieder commented 4 months ago

I'm just not sure yet if this will fix only the files affected by the PR (which should be how this works) or if it checks all other files too (which I really really don't want). Need to be sure of that before merging.

stale[bot] commented 2 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.