search

amusecode / amuse

Astrophysical Multipurpose Software Environment. This is the main repository for AMUSE
http://www.amusecode.org
Apache License 2.0
154 stars 98 forks source link

Use "interaction_radius" as alternative to "radius" for collision detection #459

Open rieder opened 5 years ago

rieder commented 5 years ago

Currently, collision detection in e.g. ph4 uses the 'radius' property of particles.

It would be beneficial to have an optional 'interaction_radius' property (not sure of the name), which would take precedence over the 'radius' property if defined.

This would make 'radius' available to store the actual stellar radius from stellar evolution.

JPGlaser commented 4 years ago

Did we actually ever make a move on this? It would simplify a channel in my code to have the attributes split.

~ Joe G.

rieder commented 4 years ago

We did not. But I’m still in favour of doing this.

JPGlaser commented 3 years ago

Circling back to this because I am getting back to active development, I can implement the change and do a merge request. @rieder 's idea of just having it check for a interaction_radius in the gravity codes and use it over radius seems like the most straight forward method that wouldn't involve any major changes to documentation.

However, we should decide on exactly what we want to call it.

~ Joe G.