search

amusecode / amuse

Astrophysical Multipurpose Software Environment. This is the main repository for AMUSE
http://www.amusecode.org
Apache License 2.0
158 stars 99 forks source link

ScalarQuantities now convert strings to floats #934

Closed rieder closed 1 year ago

rieder commented 1 year ago

Possible solution for #172, if it doesn't break anything

rieder commented 1 year ago

I think this is ok, I can't think of a reason why a quantity would consist of a string with a unit... Currently it's possible and this can lead to weird errors.

rieder commented 1 year ago

units.stellar_type is probably a case that should be handled differently?

rieder commented 1 year ago

ah, that's not a ScalarQuantity.