search

amusecode / amuse

Astrophysical Multipurpose Software Environment. This is the main repository for AMUSE
http://www.amusecode.org
Apache License 2.0
154 stars 98 forks source link

Development build produces files not in .gitignore #979

Open LourensVeen opened 1 year ago

LourensVeen commented 1 year ago

Describe the bug After building in development mode, git status shows a bunch of files that were generated by the build but aren't being ignored. If they're not ignored, they risk being accidentally included in a commit.

To Reproduce python setup.py develop_build (after installing prerequisites etc. according to the manual)

Expected behavior None of the generated files are shown by git status, because they're all covered by .gitignore.

Logs

$ git status
On branch main
Your branch is up to date with 'origin/main'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        Makefile
        src/amuse/community/distributed/data/
        src/amuse/community/galactics/data/
        src/amuse/community/mesa_r2208/data/input/star_data/starting_models/zams_z20m3.data
        src/amuse/community/mesa_r2208/mesa_reqs/star
        src/amuse/community/mocassin/data/
        src/amuse/community/phigrape/build_mpi/
        src/amuse/community/phigrape/glworker_code.f90
        src/amuse/community/phigrape/interface.mpio
        src/amuse/community/tupan/src/
        src/amuse/community/vader/0e6357b451e6.tar.gz
        src/amuse/community/vader/build_cmzdisk/
        src/amuse/community/vader/build_cmzdisk2/
        src/amuse/community/vader/build_gidisk/
        src/amuse/community/vader/build_none/
        src/amuse/community/vader/build_pedisk/
        src/amuse/community/vader/build_ring/
        src/amuse/community/vader/build_ringrad/
        src/amuse/community/vader/build_selfsim/
        src/amuse/community/vader/src/
        src/amuse/community/vader/vader_src/
        src/amuse/community/vader/vader_worker_cmzdisk
        src/amuse/community/vader/vader_worker_cmzdisk2
        src/amuse/community/vader/vader_worker_gidisk
        src/amuse/community/vader/vader_worker_none
        src/amuse/community/vader/vader_worker_pedisk
        src/amuse/community/vader/vader_worker_ring
        src/amuse/community/vader/vader_worker_ringrad
        src/amuse/community/vader/vader_worker_selfsim

nothing added to commit but untracked files present (use "git add" to track)

Environment (please complete the following information):

Additional context The .gitignore file contains many paths already, probably it just needs to be updated.

rieder commented 1 year ago

It's quite likely .gitignore wasn't updated - at least not for vader.

LourensVeen commented 1 year ago

Okay, I'll have a look at the rest, but they look like build files too. I'll go make a patch and a PR.