search

amusecode / amuse

Astrophysical Multipurpose Software Environment. This is the main repository for AMUSE
http://www.amusecode.org
Apache License 2.0
154 stars 98 forks source link

remove set_acceleration from all interfaces #994

Closed rieder closed 4 months ago

rieder commented 11 months ago

fixes #862

stale[bot] commented 9 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

stale[bot] commented 6 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 28 days if no further activity occurs. Thank you for your contributions.

LourensVeen commented 6 months ago

I'm not sure if I'm supposed to be reviewing PRs, but why not? Maybe we should discuss that actually, what the process is that we're using.

There's a bit of context missing from the description, but I'm guessing from the comment in community/interface/gd.py that this was physically unsound, and is therefore being removed?

I'm seeing a few more files with set_acceleration in them that should probably be updated too:

rieder commented 4 months ago

I'm not sure if I'm supposed to be reviewing PRs, but why not? Maybe we should discuss that actually, what the process is that we're using.

There's a bit of context missing from the description, but I'm guessing from the comment in community/interface/gd.py that this was physically unsound, and is therefore being removed?

Yes, that's correct. The codes will always overwrite the acceleration, so setting this is misleading.

I'm seeing a few more files with set_acceleration in them that should probably be updated too:

* `src/amuse/community/mpiamrvac/interface.py`

* `src/amuse/community/mpiamrvac/interface.t`

* `src/amuse/test/suite/core_tests/test_bridge.py`

* `src/amuse/test/suite/codes_tests/test_mpiamrvac.py`

In these cases it seems to be used in a different way, maybe needs to be addressed but that would be a different PR.

* `doc/tutorial/simplegrav/interface_1.cc`

* `doc/reference/stellar_dynamics_interface_specification.rst`

Updated.