search

amv-dev / yata

Yet Another Technical Analysis library [for Rust]
Apache License 2.0
321 stars 49 forks source link

ohlcv merge operator #22

Closed Igosuki closed 2 years ago

Igosuki commented 2 years ago

Hi Dmitry, first of all great work on this library, I also wanted to fork ta so it saves me a lot of time.

I'm using candles with more added info, and figured it would be good to use the sequence operators with a custom candle type.

amv-dev commented 2 years ago

Hello! Thank you for you contribution. Unfortunately this improvement breaks backward compatibility a little bit, so it may be released only in 0.6.0 . Also I want to investigate this problem to try to reduce trait requirements in collapse_timeframe method.

Igosuki commented 2 years ago

np, let me know if I can do more

amv-dev commented 2 years ago

Well, I just released a new version.

It has almost the same approach, as in your PR, but uses std::ops::Add trait instead of adding a new one.

Igosuki commented 2 years ago

Ok, I migrated to use Add, thank you and let me know if you need help on the project in the future.