search

amv-dev / yata

Yet Another Technical Analysis library [for Rust]
Apache License 2.0
321 stars 49 forks source link

enforce float_cmp check and use approx library for unit testing only #4

Closed olexiyb closed 3 years ago

amv-dev commented 3 years ago

For now I don't think it is good idea to add whole dependency only because of single simple function. I've just added same functionality in yata::helpers::assert_eq_float and yata::helpers::assert_neq_float. All the tests are also refactored using this functions.

olexiyb commented 3 years ago

your library is your call :-) But I personally would prefer to use an external library than a copy from it.