search

amwmedia / eslint-plugin-woke

MIT License
33 stars 2 forks source link

Support comments #8

Open ariesclark opened 2 years ago

ariesclark commented 2 years ago

This plugin doesn't support comment contents, can we add another rule or add it to the existing one?

amwmedia commented 2 years ago

Comments should be supported already. https://github.com/amwmedia/eslint-plugin-woke/blob/master/lib/index.js#L95-L105

christoph-pflueger commented 2 years ago

Not all comments seem to get recognized.

Reproducible example:

.eslintrc.json

{
  "plugins": ["woke"],
  "rules": {
    "woke/all": "error"
  }
}

index.js

// Comment #1

// his

package.json

{
  "name": "test",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "lint": "eslint .",
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "eslint": "8.14.0",
    "eslint-plugin-woke": "1.0.1"
  }
}

Result: No error

$ pnpm run lint

> test@1.0.0 lint /home/dev/projects/test
> eslint .