Reveal password icon is the wrong color in dark mode

amwx / FluentAvalonia

Control library focused on fluent design and bringing more WinUI controls into Avalonia

MIT License

1.05k stars 97 forks source link

Reveal password icon is the wrong color in dark mode #523

Closed styris-ame closed 9 months ago

styris-ame commented 9 months ago

Describe the bug Reveal password button icon is the wrong color when using dark mode. Note that on hover it turns to the correct color (white) and back to the wrong color (black) when unhovered.

Screenshots FAControlsGallery Desktop_dagxcqQKrW

Desktop/Platform (please complete the following information):

OS: Windows 11
FluentAvalonia Version Latest (cloned)
Avalonia Version Latest (cloned)

robloo commented 9 months ago

Note that this issue also occurs in some other places. For example, the NavigationView.PaneCustomContent (with a button).

amwx commented 9 months ago

Fixed in the above commit

@robloo I'm not seeing an issue testing this myself, and there are no setters that force a foreground around the PaneCustomContent. The TextBox button issue was a result of me originally hardcoding the foreground for the icon within the template, I've moved that out to setters and dynamic resources. Have you checked your button styles to make sure you're not accidentally using static resource or something that causes the button icon to render in black text?

robloo commented 9 months ago

@amwx Thanks for double checking. I'll for sure dig into this more on my end and see if the problem is in the app. If not will open a separate PR with a fix.